[QIR] Insert array record call in sampling workflow #3553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inset an array recording output call pripr to any record result calls. This pass should be used in `sample` workflow. Signed-off-by: Pradnya Khalate <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
schweitzpgi
reviewed
Nov 13, 2025
schweitzpgi
reviewed
Nov 13, 2025
schweitzpgi
reviewed
Nov 13, 2025
schweitzpgi
reviewed
Nov 13, 2025
|
|
||
| LLVM_DEBUG(llvm::dbgs() << "Before adding array recording call:\n" | ||
| << *funcOp); | ||
| if (failed(insertArrayRecordingCalls(funcOp, analysis.arraySize, |
Collaborator
There was a problem hiding this comment.
Should use the intrinsic loading instead of rolling your own. Aren't these already loaded by the QIR API Prep pass, though?
Collaborator
Author
There was a problem hiding this comment.
I wanted to make this pass self-contained, since we cannot guarantee that the prep pass has run before this one.
Should I move the loadIntrinsic call from line#176 here?
schweitzpgi
reviewed
Nov 13, 2025
schweitzpgi
reviewed
Nov 13, 2025
Signed-off-by: Pradnya Khalate <[email protected]>
khalatepradnya
force-pushed
the
insert-array-record
branch
from
ff1bb2a to
c774568
Compare
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
* Update label to be of type `i1` instead of `i8` since we interpret the results as Booleans. * Test for parser. Signed-off-by: Pradnya Khalate <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Pradnya Khalate <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new module pass,
QirInsertArrayRecord, that analyzes instruction patterns and inserts array recording instruction required for proper measurement result handling in QIR pipelines. The pass identifies measurement storage patterns and ensures the QIR output declares the correct array size and type label for measurement results.This PR also enables the pass in compilation workflow.